]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
notification: be compatible with various names of the icon data hint
authorCosimo Cecchi <cosimoc@gnome.org>
Wed, 19 Jan 2011 15:30:01 +0000 (16:30 +0100)
committerCosimo Cecchi <cosimoc@gnome.org>
Wed, 19 Jan 2011 16:31:23 +0000 (17:31 +0100)
The hint changed its name during various iterations of the
notification daemon spec; be compatible with all of them.

https://bugzilla.gnome.org/show_bug.cgi?id=639959

js/ui/notificationDaemon.js

index 0b377a834a5e54dfa7d4a99f3930497412cefe55..63062794eec9ed872f101966b4ecf115b429b1fd 100644 (file)
@@ -146,9 +146,9 @@ NotificationDaemon.prototype = {
                 return new St.Icon({ icon_name: icon,
                                      icon_type: St.IconType.FULLCOLOR,
                                      icon_size: size });
-        } else if (hints.icon_data) {
+        } else if (hints['image-data']) {
             let [width, height, rowStride, hasAlpha,
-                 bitsPerSample, nChannels, data] = hints.icon_data;
+                 bitsPerSample, nChannels, data] = hints['image-data'];
             return textureCache.load_from_raw(data, data.length, hasAlpha,
                                               width, height, rowStride, size);
         } else {
@@ -238,6 +238,15 @@ NotificationDaemon.prototype = {
 
         hints = Params.parse(hints, { urgency: Urgency.NORMAL }, true);
 
+        // Be compatible with the various hints for image data
+        // 'image-data' is the latest name of this hint, introduced in 1.2
+        if (!hints['image-data']) {
+            if (hints['image_data'])
+                hints['image-data'] = hints['image_data']; // version 1.1 of the spec
+            else if (hints['icon_data'])
+                hints['image-data'] = hints['icon_data']; // previous versions of the spec
+        }
+
         let ndata = { appName: appName,
                       icon: icon,
                       summary: summary,